Printing large numbers with comma seperator

[See_Mos]

Help please, I am definitely losing the plot.  I have done this a long time ago but cannot remember how or find the old code.

All I need to do is print a DWord variable with comma separators so 123456789 shows on the LCD as 123,456,789.

[RGV250]

Hi,
I can't try at the moment but converting to string and using mid$ etc is my guess.

Bob

[See_Mos]

I'm not alone then?

I get the correct display with this but I am sure there is a neater way.

Dim Big_number As Dword
Dim P1 As Dword
Dim P2 As Dword
Dim P3 As Dword

    Big_number = 980650320
    Print At 1,1,Dec Big_number   
    P1 = Big_number // 1000
    P2 = Big_number / 1000
    P2 = P2 //1000
    P3 = Big_number /1000000

    Print At 3,1,Dec3 P3,",",Dec3 P2,",",Dec3 P1 

[top204]

That is the way I always display values that require comma or decimal point delimiters.

It can be done with String variable manipulation, but division and remainder is the nicest method.

Below is a code listing I've just created, which is, essentially, the same as your method:

Code Select Expand

'
'   /\\\\\\\\\
'  /\\\///////\\\
'  \/\\\     \/\\\                                                 /\\\          /\\\
'   \/\\\\\\\\\\\/        /\\\\\     /\\\\\\\\\\     /\\\\\\\\   /\\\\\\\\\\\  /\\\\\\\\\\\  /\\\\\\\\\
'    \/\\\//////\\\      /\\\///\\\  \/\\\//////    /\\\/////\\\ \////\\\////  \////\\\////  \////////\\\
'     \/\\\    \//\\\    /\\\  \//\\\ \/\\\\\\\\\\  /\\\\\\\\\\\     \/\\\         \/\\\        /\\\\\\\\\\
'      \/\\\     \//\\\  \//\\\  /\\\  \////////\\\ \//\\///////      \/\\\ /\\     \/\\\ /\\   /\\\/////\\\
'       \/\\\      \//\\\  \///\\\\\/    /\\\\\\\\\\  \//\\\\\\\\\\    \//\\\\\      \//\\\\\   \//\\\\\\\\/\\
'        \///        \///     \/////     \//////////    \//////////      \/////        \/////     \////////\//
'                                  Let's find out together what makes pValue PIC Tick!
'
' Transmit delimited values to a serial terminal.
'
' Written for the Positron8 compiler by Les Johnson.
' https://sites.google.com/view/rosetta-tech/positron-compilers-experimenters-notebook
'
    Device = 18F25K20                                                   ' Tell the compiler what device to compile for
    Declare Xtal = 16                                                   ' Tell the compiler what frequency the device will be operating at (in MHz)
    Declare Auto_Heap_Strings = On                                      ' Tell the compiler to create Strings above standard variables, so assembler code is more efficient
    Declare Auto_Variable_Bank_Cross = On                               ' Tell the compiler to create any multi-byte variables in the same RAM bank. For more efficiency
'
' Setup USART1
'
    Declare Hserial_Baud = 9600                                         ' Set the Baud rate to 9600
    Declare HRSOut1_Pin  = PORTC.6                                      ' Set the TX pin
'
' Create Global variables here
'
    Dim MyDWord As Dword
   
'-------------------------------------------------------------------------------------------------------------
' The main program starts here
' Transmit delimited values to a serial terminal
'
Main:
    MyDWord = 12
    HRSOut1Ln Dec MyDWord, "        is ", CommaDelim(MyDWord)
   
    MyDWord = 123
    HRSOut1Ln Dec MyDWord, "       is ", CommaDelim(MyDWord)

    MyDWord = 1234
    HRSOut1Ln Dec MyDWord, "      is ", CommaDelim(MyDWord)
   
    MyDWord = 12345
    HRSOut1Ln Dec MyDWord, "     is ", CommaDelim(MyDWord)
   
    MyDWord = 123456
    HRSOut1Ln Dec MyDWord, "    is ", CommaDelim(MyDWord)
   
    MyDWord = 1234567
    HRSOut1Ln Dec MyDWord, "   is ", CommaDelim(MyDWord)
   
    MyDWord = 12345678
    HRSOut1Ln Dec MyDWord, "  is ", CommaDelim(MyDWord)

    MyDWord = 123456789
    HRSOut1Ln Dec MyDWord, " is ", CommaDelim(MyDWord)

'-------------------------------------------------------------------------------------------------------------
' Comma delimit an integer value
' Input     : pValue holds the value to convert to a delimited string
' Output    : Returns the comma delimited String
' Notes     : None
'
Proc CommaDelim(pValue As Dword), String * 20
    Result = Str$(Dec, pValue / 1000000) + "," + Str$(Dec, (pValue // 1000000) / 1000) + "," + Str$(Dec, pValue // 1000)      
EndProc

On the serial terminal, it will display:

12        is 0,0,12
123       is 0,0,123
1234      is 0,1,234
12345     is 0,12,345
123456    is 0,123,456
1234567   is 1,234,567
12345678  is 12,345,678
123456789 is 123,456,789

Beginning 0 values can be eliminated in the procedure by using a temporary variable for the divisions, and only adding the value and comma to the Result if it is not 0 etc, such as in the simple procedure listed below:

Code Select Expand

'-------------------------------------------------------------------------------------------------------------
' Comma delimit an integer value
' Input     : pValue holds the value to convert to a delimited string
' Output    : Returns the comma delimited String
' Notes     : Eliminates leading zeroes
'
Proc CommaDelim(pValue As Dword), String * 20
    Dim dTemp As Dword

    Clear Result
    If pValue = 0 Then
        Result = "0"
        ExitProc
    EndIf
       
    dTemp = pValue / 1000000
    If dTemp > 0 Then
        Result = Result + Str$(Dec, dTemp) + ","
    EndIf
    
    dTemp = (pValue // 1000000) / 1000
    If dTemp > 0 Then
        Result = Result + Str$(Dec, dTemp) + ","
    EndIf
  
    dTemp = pValue // 1000
    If dTemp > 0 Then
        Result = Result + Str$(Dec, dTemp)
    EndIf
EndProc

And on the serial terminal, it will display:

12        is 12
123       is 123
1234      is 1,234
12345     is 12,345
123456    is 123,456
1234567   is 1,234,567
12345678  is 12,345,678
123456789 is 123,456,789

Regards
Les

[Pepe]

demo proteus